Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] gnomeExtensions.dash-to-panel: 38 -> 40 #106029

Closed
wants to merge 2 commits into from
Closed

[20.09] gnomeExtensions.dash-to-panel: 38 -> 40 #106029

wants to merge 2 commits into from

Conversation

buckley310
Copy link
Contributor

@buckley310 buckley310 commented Dec 6, 2020 •
edited

Motivation for this change

Backport v40 to resolve #105001
(from #103702)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 6, 2020
@prusnak
Copy link
Member

prusnak commented Dec 20, 2020

Please cherry pick from master using git cherry-pick -x so the commit message contains the reference to the original commit (see CONTRIBUTING.md where this is described).

dawidsowa and others added 2 commits December 20, 2020 22:14
@dawidsowa @buckley310
gnomeExtensions.dash-to-panel: 38 -> 39 (NixOS#97840)
19b6588 
(cherry picked from commit 5d50bb6)

Backported to resolve breaking issues with GNOME 3.36.4
@buckley310
gnomeExtensions.dash-to-panel: 39 -> 40
e82920a 
(cherry picked from commit 67394b5)

Backported to resolve breaking issues with GNOME 3.36.4
@buckley310
Copy link
Contributor Author

I have re-reviewed the doc and corrected the errors. Sorry for the sloppiness.

@buckley310
Copy link
Contributor Author

Nobody seems to care enough to test this PR, and 21.05 is right around the corner. Closing.

@buckley310 buckley310 closed this Apr 5, 2021
@buckley310 buckley310 deleted the nixos-20.09 branch June 9, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buckley310 @prusnak @dawidsowa