Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixjson: init at 1.1.1 #106004

Merged
merged 1 commit into from Dec 7, 2020
Merged

fixjson: init at 1.1.1 #106004

merged 1 commit into from Dec 7, 2020

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Dec 5, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Dec 5, 2020
View reviewed changes
pkgs/development/node-packages/composition.nix Outdated Show resolved Hide resolved
pkgs/development/node-packages/node-env.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from midchildan December 5, 2020 19:54
@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 6, 2020

@SuperSandro2000 Can this be merged?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106004 run on x86_64-darwin 1

2 packages failed to build:
  • lumo
  • tests.writers
2 packages built:
  • iosevka
  • vscode-extensions.matklad.rust-analyzer

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 7, 2020 •
edited

Result of nixpkgs-review pr 106004 run on x86_64-linux 1

2 packages failed to build:
  • iosevka
  • lumo
23 packages built:
  • bitwarden-cli
  • castnow
  • emojione
  • epgstation
  • flood
  • gtop
  • image_optim
  • joplin
  • mirakurun
  • netlify-cli
  • pm2
  • ripcord
  • tests.writers
  • thelounge
  • twemoji-color-font
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb

both builds are failing due to timeouts and the lack of free RAM on my machine to compile v8.

@SuperSandro2000 SuperSandro2000 merged commit b18ce5c into NixOS:master Dec 7, 2020
@cpcloud cpcloud deleted the fixjson branch May 11, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan midchildan approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpcloud @SuperSandro2000 @midchildan