Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sauerbraten: 5492 -> 2020-12-04 #106033

Closed
wants to merge 1 commit into from
Closed

sauerbraten: 5492 -> 2020-12-04 #106033

wants to merge 1 commit into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 6, 2020

Motivation for this change

http://www.sauerworld.org/new-sauerbraten-2020-edition-released/

I haven't tested the server, the client seems to run, I'll try and see how much of my practice I've lost and mark as ready afterwards.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Dec 6, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message and PR title to sauerbraten: 5492 -> 2020-12-04.

@ajs124
Copy link
Member Author

ajs124 commented Dec 6, 2020

5492 was a random svn revision, but I can change it if you think that's really necessary. It does however not seem to store settings right now, so I'll need to fix that.

@SuperSandro2000
Copy link
Member

5492 was a random svn revision, but I can change it if you think that's really necessary.

It is the current version in nixpkgs so please change it.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106033 run on x86_64-linux 1

1 package built:
  • sauerbraten

@ajs124 ajs124 marked this pull request as ready for review December 7, 2020 03:33
@teto
Copy link
Member

teto commented Dec 7, 2020

passed nixpkgs-review here. I tried to run the binary and it worked fine with the exceptiuon I had no audio. It may come from my setup though so if someone could check.

@SuperSandro2000 SuperSandro2000 changed the title sauerbraten: update to 2020-12-04 sauerbraten: 5492 -> 2020-12-04 Dec 8, 2020
@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 8, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Replaced by #106317 because I cannot force push the commit message and noticed that to late.

@ajs124 ajs124 deleted the upd/sauerbraten branch December 10, 2020 21:04
@ajs124
Copy link
Member Author

ajs124 commented Dec 10, 2020

I'd appreciate if you'd never do that again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @SuperSandro2000 @teto