Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] marker: init at 2020.04.04 #106032

Closed
wants to merge 1 commit into from
Closed

[20.09] marker: init at 2020.04.04 #106032

wants to merge 1 commit into from

Conversation

trepetti
Copy link
Contributor

@trepetti trepetti commented Dec 6, 2020

Backporting to 20.09 at user request.

(cherry picked from commit 7559a99)

Motivation for this change

User request to backport to 20.09: #100653 (comment)

Needs confirmation: #100653 (comment)

CC: @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trepetti
marker: init at 2020.04.04
4c6e76d 
Backporting to 20.09 at user request.

(cherry picked from commit 7559a99)
@trepetti trepetti changed the title marker: init at 2020.04.04 (backport to 20.09) [20.09] marker: init at 2020.04.04 Dec 6, 2020
@trepetti
Copy link
Contributor Author

@alexeymuranov in the meantime as we wait for a review, you may enjoy Apostrophe. That's what I've been using recently. The side by side view IMO is nicer than Marker. Only found it after I'd packaged Marker, of course :-)

https://github.com/ApostropheEditor/Apostrophe

@alexeymuranov
Copy link
Contributor

alexeymuranov commented Dec 14, 2020 •
edited

@trepetti, thanks, i already have it, but somehow i've got used to marker (installed with flatpak, with some issues).

rmcgibbo
rmcgibbo approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and the app works on x86_64-linux.

@trepetti
Copy link
Contributor Author

Thanks for the review, @rmcgibbo. Will close this one, though, since 21.05 is just around the corner which more-or-less obsoletes this PR.

@trepetti trepetti closed this May 12, 2021
@trepetti trepetti deleted the marker-backport branch May 12, 2021 12:41
@jonringer
Copy link
Contributor

oops, looks like i had a pending review from long, long ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo rmcgibbo approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trepetti @alexeymuranov @jonringer @rmcgibbo