Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero 0.17.1.3 -> 0.17.1.5 #106010

Merged
merged 2 commits into from Dec 6, 2020
Merged

monero 0.17.1.3 -> 0.17.1.5 #106010

merged 2 commits into from Dec 6, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 5, 2020

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Notes: my client stopped synchronising to the remote node, maybe it's unrelated but it would be good if someone could confirm.

@rnhmjoj rnhmjoj requested a review from prusnak December 5, 2020 18:44
@rnhmjoj rnhmjoj changed the title 0.17.1.3 -> 0.17.1.5 monero 0.17.1.3 -> 0.17.1.5 Dec 5, 2020
@ofborg ofborg bot requested a review from ehmry December 5, 2020 18:56
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 5, 2020

Result of nixpkgs-review pr 106010 1 on darwin

1 package marked as broken and skipped:
  • monero-gui
1 package built:
  • monero

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106010 run on x86_64-linux 1

2 packages built:
  • monero
  • monero-gui

@RaghavSood
Copy link
Member

Any reason why we aren't bumping up to v0.17.1.5 for both?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 6, 2020

Any reason why we aren't bumping up to v0.17.1.5 for both?

Am I missing something? Isn't it what this PR is doing?

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 106010 run on x86_64-linux 1

2 packages built:
  • monero
  • monero-gui

@RaghavSood
Copy link
Member

@rnhmjoj Total brain fart on my end, apologies - thought one of them was going from 0.17.1.3 -> 0.17.1.4.

LGTM

@RaghavSood RaghavSood merged commit 6c94fd9 into NixOS:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants