Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] openssh: Fix EOF: command not found #106019

Merged
merged 1 commit into from Dec 8, 2020
Merged

[20.09] openssh: Fix EOF: command not found #106019

merged 1 commit into from Dec 8, 2020

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Dec 5, 2020

Backport from 21.03

(cherry picked from commit 4c8c8d2)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from aneeshusa and edolstra December 5, 2020 21:02
@r-burns
Copy link
Contributor

r-burns commented Dec 5, 2020

I think this should target staging-20.09 due to volume of rebuilds

@otavio otavio changed the base branch from release-20.09 to staging-20.09 December 5, 2020 23:13
@otavio
Copy link
Contributor Author

otavio commented Dec 5, 2020

@r-burns, thanks. I updated the PR.

@jonringer
Copy link
Contributor

@GrahamcOfBorg test openssh

r-burns
r-burns approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repro'd issue locally and verified that this patch fixes it. Diff LGTM too.

@mweinelt mweinelt added this to Ready in Staging (stable) Dec 8, 2020
@jonringer jonringer merged commit eff6959 into NixOS:staging-20.09 Dec 8, 2020
Staging (stable) automation moved this from Ready to Done Dec 8, 2020
@aneeshusa aneeshusa mentioned this pull request Dec 12, 2020
Closed
@otavio otavio deleted the backport-20.09 branch December 31, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@r-burns r-burns r-burns approved these changes

@aneeshusa aneeshusa Awaiting requested review from aneeshusa

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@otavio @r-burns @jonringer