Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.coremltools: init at 4.1 #105834

Closed
wants to merge 1 commit into from
Closed

python3Packages.coremltools: init at 4.1 #105834

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 3, 2020 •
edited

Motivation for this change

New package for working with Machine Learning Models

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 3, 2020
View reviewed changes
pkgs/development/python-modules/coremltools/default.nix Outdated

# skip tests which require downloaded models or macOS
checkPhase = ''
pytest -k "not (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pytestCheckHook together with disabledTests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in f7777b8c133b821e5098dae6a317be7ca2ebf724

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 4, 2020 •
edited

Result of nixpkgs-review pr 105834 run on x86_64-linux 1

2 packages failed to build:
  • python37Packages.coremltools
  • python39Packages.coremltools
1 package built:
  • python38Packages.coremltools

Python37 fails due to test failures related to pytorch and python39 fails because boto fails to build.

image

@prusnak
Copy link
Member Author

prusnak commented Dec 4, 2020

In f7777b8c133b821e5098dae6a317be7ca2ebf724 I disabled test for everything else except Python 3.8

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105834 1 on darwin

3 packages failed to build:
  • python37Packages.coremltools
  • python38Packages.coremltools
  • python39Packages.coremltools

Basically all tests fail.

@SuperSandro2000
Copy link
Member

In f7777b8 I disabled test for everything else except Python 3.8

Please fix the eval error. isPy38 is undefined.

@prusnak
Copy link
Member Author

prusnak commented Dec 4, 2020

Please fix the eval error. isPy38 is undefined.

Fixed in 54bc78099b4f7e8c89807a2d6812985e8678deb0.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105834 run on x86_64-linux 1

3 packages built:
  • python37Packages.coremltools
  • python38Packages.coremltools
  • python39Packages.coremltools

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 11, 2020 •
edited

Result of nixpkgs-review pr 105834 run on x86_64-darwin 1

1 package failed to build:
  • python38Packages.coremltools
2 packages built:
  • python37Packages.coremltools
  • python39Packages.coremltools
E                   Exception: Unable to load CoreML.framework. Cannot make prediction

I think CoreML is a darwin framework which is not available in nixpkgs, yet.

@prusnak prusnak changed the title python3Packages.coremltools: init at 4.0 python3Packages.coremltools: init at 4.1 Mar 23, 2021
@prusnak prusnak closed this Aug 23, 2021
@prusnak prusnak deleted the coremltools branch August 23, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @SuperSandro2000