Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: codimd: 1.6.0 -> 1.7.0, rename to hedgedoc #105800

Closed
wants to merge 1 commit into from
Closed

WIP: codimd: 1.6.0 -> 1.7.0, rename to hedgedoc #105800

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2020 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from WilliButz, globin and Ma27 December 3, 2020 15:50
@Ma27
Copy link
Member

Ma27 commented Dec 3, 2020

I assume that this is a duplicate to #105385?

@ghost ghost closed this Dec 3, 2020
@ghost
Copy link
Author

ghost commented Dec 3, 2020

Yes. I looked when I first noticed 1.7.0 candidates being available a few days ago and didn't check again. The other PR is better in some regards, just needs to be updated to rc2.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz Awaiting requested review from WilliButz

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ma27