Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio-experimental, factorio-headless-experimental: 1.1.3 -> 1.1.4 #105805

Merged
merged 1 commit into from Dec 3, 2020
Merged

factorio-experimental, factorio-headless-experimental: 1.1.3 -> 1.1.4 #105805

merged 1 commit into from Dec 3, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Dec 3, 2020

Motivation for this change

https://forums.factorio.com/viewtopic.php?f=3&p=525324

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb lukegb changed the title factorio: 1.1.3 -> 1.1.4 factorio-experimental, factorio-headless-experimental: 1.1.3 -> 1.1.4 Dec 3, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105805 run on x86_64-linux 1

1 package failed to build:
  • factorio-experimental
1 package built:
  • factorio-headless-experimental

@SuperSandro2000 SuperSandro2000 merged commit be952f2 into NixOS:master Dec 3, 2020
@lukegb lukegb deleted the factorio114 branch December 3, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @SuperSandro2000