Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implicitcad: init at 0.3.0.0 #105798

Closed
wants to merge 1 commit into from
Closed

implicitcad: init at 0.3.0.0 #105798

wants to merge 1 commit into from

Conversation

simonvpe
Copy link
Contributor

@simonvpe simonvpe commented Dec 3, 2020

A math-inspired programmatic 2D & 3D CAD system

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

implicitcad: init at 0.3.0.0
d67e6c8 
A math-inspired programmatic 2D & 3D CAD system
@sorki
Copy link
Member

sorki commented Dec 3, 2020

Thanks tho - I don't think this is necessary as it's already distributed as part of Haskell package set.

It's also getting a lot of refactoring / usability improvements recently so next version should fix remaining issues with it (extended haddocks, disabled implicitsnap / benchmarks by default).

See https://github.com/colah/ImplicitCAD/blob/master/CHANGELOG.md

You might want grab repo and use nix-shell / nix-build till the release. I think it won't take long as it's stabilizing pretty nicely atm.

Also the addition of you as a maintainer should be separate commit.

@sorki
Copy link
Member

sorki commented Dec 3, 2020

It might be a good idea to expose this from pkgs/top-level/all-packages.nix similar to e.g. dhall or update-nix-fetchgit packages.

@simonvpe
Copy link
Contributor Author

simonvpe commented Dec 7, 2020

Thank you! I'm closing this then.

@simonvpe simonvpe closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonvpe @sorki