Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/msmtp: add msmtp module #105831

Merged
merged 1 commit into from Dec 30, 2020
Merged

nixos/msmtp: add msmtp module #105831

merged 1 commit into from Dec 30, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Dec 3, 2020

Motivation for this change

This adds a module for msmtp, a simple SMTP client which provides a
sendmail-compatible interface.

GitHub: see also nixpkgs issue #105710

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Tested importing and using the module out-of-tree
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
nixos/msmtp: add msmtp module
93335aa 
This adds a module for msmtp, a simple SMTP client which provides a
sendmail-compatible interface.

GitHub: see also nixpkgs issue NixOS#105710
@pacien pacien mentioned this pull request Dec 3, 2020
Closed
3 tasks
@veprbl veprbl linked an issue Dec 3, 2020 that may be closed by this pull request
Replace ssmtp with msmtp (which needs a corresponding module) #105710
Closed
3 tasks
@veprbl veprbl removed a link to an issue Dec 3, 2020
Replace ssmtp with msmtp (which needs a corresponding module) #105710
Closed
3 tasks
roosemberth
roosemberth approved these changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@roosemberth roosemberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/305

@AndersonTorres
Copy link
Member

Can it be ported to Stable?

@AndersonTorres AndersonTorres merged commit d7cf898 into NixOS:master Dec 30, 2020
@pacien pacien mentioned this pull request Dec 30, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roosemberth roosemberth roosemberth approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @nixos-discourse @AndersonTorres @roosemberth