Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatling: 0.15 -> 0.16 #105830

Merged
merged 4 commits into from Dec 8, 2020
Merged

gatling: 0.15 -> 0.16 #105830

merged 4 commits into from Dec 8, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Dec 3, 2020

Motivation for this change

Version bump. Fixes compatibility with current libowfat.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
Copy link
Member Author

wamserma commented Dec 3, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Dec 3, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 3, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@wamserma
Copy link
Member Author

wamserma commented Dec 3, 2020

/status needs_reviewer

@ofborg ofborg bot requested a review from makefu December 3, 2020 21:33
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105830 run on x86_64-linux 1

3 packages built:
  • gatling
  • libowfat
  • opentracker

@wamserma @SuperSandro2000
opentracker: combine calls to substituteInPlace (refactoring)
3e27c46 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 7, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

makefu
makefu approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested gatling locally together with curl, everything looks fine.
opentracker also starts up.

@Mic92
Copy link
Member

Mic92 commented Dec 7, 2020

/status needs_changes

@ofborg ofborg bot requested a review from makefu December 7, 2020 22:57
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105830 run on x86_64-linux 1

3 packages built:
  • gatling
  • libowfat
  • opentracker

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105830 run on x86_64-darwin 1

@SuperSandro2000 SuperSandro2000 merged commit ea549c4 into NixOS:master Dec 8, 2020
@wamserma wamserma deleted the gatling16 branch January 8, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Mic92 Mic92 Awaiting requested review from Mic92

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wamserma @SuperSandro2000 @Mic92 @makefu