Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpExtensions.ftp: enable FTPS support #105808

Closed
wants to merge 1 commit into from
Closed

phpExtensions.ftp: enable FTPS support #105808

wants to merge 1 commit into from

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 3, 2020

Motivation for this change

Enable FTPS support.

cc @NixOS/php

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin mentioned this pull request Dec 3, 2020
Closed
@Izorkin Izorkin changed the title phpExtensions..ftp: enable FTPS support phpExtensions.ftp: enable FTPS support Dec 3, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105808 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • hhvm
  • php73Packages.phpmd
13 packages failed to build:
  • drush
  • php73
  • php73Extensions.ftp
  • php73Packages.box
  • php73Packages.composer
  • php73Packages.composer2
  • php73Packages.php-cs-fixer
  • php73Packages.php-parallel-lint
  • php73Packages.phpcbf
  • php73Packages.phpcs
  • php73Packages.phpstan
  • php73Packages.psalm
  • php73Packages.psysh
43 packages built:
  • adminer
  • arcanist
  • icingaweb2
  • libsForQt5.kcachegrind (kdeApplications.kcachegrind ,libsForQt515.kcachegrind)
  • libsForQt512.kcachegrind
  • libsForQt514.kcachegrind
  • lsp-plugins
  • matomo
  • matomo-beta
  • nagios
  • nextcloud-news-updater
  • phoronix-test-suite
  • php (php74)
  • phpExtensions.ftp (php74Extensions.ftp)
  • phpPackages.box (php74Packages.box)
  • phpPackages.composer (php74Packages.composer)
  • phpPackages.composer2 (php74Packages.composer2)
  • phpPackages.php-cs-fixer (php74Packages.php-cs-fixer)
  • phpPackages.php-parallel-lint (php74Packages.php-parallel-lint)
  • phpPackages.phpcbf (php74Packages.phpcbf)
  • phpPackages.phpcs (php74Packages.phpcs)
  • phpPackages.phpmd (php74Packages.phpmd)
  • phpPackages.phpstan (php74Packages.phpstan)
  • phpPackages.psalm (php74Packages.psalm)
  • phpPackages.psysh (php74Packages.psysh)
  • php80
  • php80Extensions.ftp
  • php80Packages.box
  • php80Packages.composer
  • php80Packages.composer2
  • php80Packages.php-cs-fixer
  • php80Packages.php-parallel-lint
  • php80Packages.phpcbf
  • php80Packages.phpcs
  • php80Packages.phpmd
  • php80Packages.phpstan
  • php80Packages.psalm
  • php80Packages.psysh
  • pulseeffects
  • qcachegrind
  • unit
  • wp-cli
  • yle-dl
  configure: error: Cannot find OpenSSL's <evp.h>

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105808 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • php80
2 packages failed to build:
  • drush
  • php73
11 packages built:
  • adminer
  • arcanist
  • icingaweb2
  • matomo
  • matomo-beta
  • nextcloud-news-updater
  • phoronix-test-suite
  • php (php74)
  • qcachegrind
  • wp-cli
  • yle-dl

php errrors with

configure: error: Cannot find OpenSSL's <evp.h>

@Izorkin Izorkin marked this pull request as draft December 6, 2020 15:09
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@etu
Copy link
Contributor

etu commented Aug 1, 2022

Will the issues mentioned here be addressed? If it is, it can be rebased, have the conflicts fixed and then the issues fixed and re-opened.

@etu etu closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar will be requested when the pull request is marked ready for review jtojnar is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse will be requested when the pull request is marked ready for review aanderse is a code owner

@drupol drupol Awaiting requested review from drupol drupol will be requested when the pull request is marked ready for review drupol is a code owner

@globin globin Awaiting requested review from globin globin will be requested when the pull request is marked ready for review globin is a code owner

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 will be requested when the pull request is marked ready for review Ma27 is a code owner

@talyz talyz Awaiting requested review from talyz talyz will be requested when the pull request is marked ready for review talyz is a code owner

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @SuperSandro2000 @etu