Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: 20.2.4 -> 20.3.1 #105817

Merged
merged 4 commits into from Dec 17, 2020
Merged

mesa: 20.2.4 -> 20.3.1 #105817

merged 4 commits into from Dec 17, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Dec 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vcunat December 3, 2020 19:19
@alapshin
Copy link
Contributor

alapshin commented Dec 4, 2020 •
edited

Are there are any plans of migrating to LLVM 11 to enable support for new AMD cards
https://www.phoronix.com/scan.php?page=news_item&px=AMDGPU-LLVM-11-Navi-2-GFX1030 ?

@primeos
Copy link
Member Author

primeos commented Dec 5, 2020

@alapshin I wasn't aware of that, thanks! IIRC upstream CI mainly uses LLVM 9 but Arch already uses LLVM 11 so I think it should be fine to switch to llvmPackages_latest to avoid such issues in the future.

@vcunat
Copy link
Member

vcunat commented Dec 5, 2020

Yes, I think mesa generally supports the currently newest LLVM and sometimes it implies additional features in drivers. This PR seems a good moment when to switch.

@jansol
Copy link
Contributor

jansol commented Dec 17, 2020

20.3.1 is out

@primeos
mesa: 20.2.4 -> 20.3.0
a9385a7
@primeos
mesa: Drop all old patches
3106113 
There's no need to keep the expressions for old patches around.
Also: Apply the musl patch unconditionally to ensure that it doesn't
break after future updates.
@primeos
mesa: Switch from LLVM 9 to llvmPackages_latest
886e497 
The radeonsi and radv (without ACO) drivers requires LLVM 11 for
GFX 10.3 [0],[1]. E.g. Arch Linux also compiles Mesa with LLVM 11 so
this should be fine.

[0]: https://docs.mesa3d.org/relnotes/20.2.0.html
[1]: NixOS#105817 (comment)
@primeos
mesa: 20.3.0 -> 20.3.1
af9f917
@primeos
Copy link
Member Author

primeos commented Dec 17, 2020

Tested r600 and iris.

@primeos primeos marked this pull request as ready for review December 17, 2020 11:31
@primeos primeos changed the title mesa: 20.2.3 -> 20.3.0 mesa: 20.2.4 -> 20.3.1 Dec 17, 2020
@primeos primeos merged commit e7b88d1 into NixOS:staging Dec 17, 2020
wakira pushed a commit to wakira/nixpkgs that referenced this pull request Dec 19, 2020
@primeos @wakira
mesa: Switch from LLVM 9 to llvmPackages_latest
56cc0cd 
The radeonsi and radv (without ACO) drivers requires LLVM 11 for
GFX 10.3 [0],[1]. E.g. Arch Linux also compiles Mesa with LLVM 11 so
this should be fine.

[0]: https://docs.mesa3d.org/relnotes/20.2.0.html
[1]: NixOS#105817 (comment)
@xaverdh xaverdh mentioned this pull request Dec 21, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@primeos @alapshin @vcunat @jansol @SuperSandro2000