Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dconf2nix: 0.0.6 -> 0.0.7 #105813

Merged
merged 1 commit into from Dec 3, 2020
Merged

dconf2nix: 0.0.6 -> 0.0.7 #105813

merged 1 commit into from Dec 3, 2020

Conversation

gvolpe
Copy link
Member

@gvolpe gvolpe commented Dec 3, 2020

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

NOTE: I built the binary as usual by running nix-build -A dconf2nix but the update is not picked up. If I run result/bin/dconf2nix -v, I still get the previous version. The previous update went well.

Did something change in how Haskell packages that are not on Hackage are built on nixpkgs?

@maralorn
Copy link
Member

maralorn commented Dec 3, 2020

@gvolpe I don‘t know what you did wrong. For me the command nix-build -A dconf2nix builds version 0.0.7 just fine.

@maralorn maralorn merged commit cc9dda5 into NixOS:master Dec 3, 2020
@gvolpe
Copy link
Member Author

gvolpe commented Dec 3, 2020

@maralorn did you run result/bin/dconf2nix -v? It prints out the previous version for me.

@gvolpe gvolpe deleted the dconf2nix-v0.0.7 branch December 3, 2020 21:20
@maralorn
Copy link
Member

maralorn commented Dec 3, 2020

I did. It printed 0.0.7.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105813 run on x86_64-darwin 1

2 packages built:
  • dconf2nix
  • haskellPackages.dconf2nix

@gvolpe
Copy link
Member Author

gvolpe commented Dec 4, 2020

Great, not sure what's going on locally then. Thanks for confirming @maralorn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gvolpe @maralorn @SuperSandro2000