Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take exclude configuration via yaml #1

Closed
mithro opened this issue Dec 3, 2020 · 7 comments · Fixed by #4
Closed

Take exclude configuration via yaml #1

mithro opened this issue Dec 3, 2020 · 7 comments · Fixed by #4

Comments

@mithro
Copy link
Contributor

mithro commented Dec 3, 2020

Currently the files excluded from the checks are hard coded in the shell scripts.

@umarcor
Copy link
Contributor

umarcor commented Dec 3, 2020

Do you mean an option when using the Action (which is a field in action.yml) or passing a "configuration file" in YAML format to the Action?

@mithro
Copy link
Contributor Author

mithro commented Dec 3, 2020

Either?

@umarcor
Copy link
Contributor

umarcor commented Dec 3, 2020

Then, I would suggest rewriting the scripts in Python, instead of using bash. Manipulating YAML in bash and/or detecting a "polimorfic" argument is a pain in comparison.

@mithro
Copy link
Contributor Author

mithro commented Dec 3, 2020

@umarcor I was hoping it could just set a list of values to an environment variable?

@umarcor
Copy link
Contributor

umarcor commented Dec 3, 2020

Sure, the point is what content/syntax we allow:

uses: symbiflow/actions/checks@main
with:
  exclude: >
    a_pattern
    another_pattern
uses: symbiflow/actions/checks@main
with:
  exclude: |
    a_pattern
    another_pattern
uses: symbiflow/actions/checks@main
with:
  exclude: exclude_list.yml

In all cases, an envvar named INPUT_EXCLUDE will contain the value(s). In the first case, values are separated by spaces. In the second case, values are separated by newlines. In the last case, reading the YAML file would be required.

@mithro
Copy link
Contributor Author

mithro commented Dec 4, 2020

First two seem fine, I don't think we need the third one at the moment?

@umarcor
Copy link
Contributor

umarcor commented Dec 4, 2020

Single exclude pattern list for all tests or one for check_license and a different one for check_python?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants