Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Appcpm: 0.995 -> 0.996 #106134

Merged
merged 1 commit into from Dec 7, 2020
Merged

perlPackages.Appcpm: 0.995 -> 0.996 #106134

merged 1 commit into from Dec 7, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Dec 7, 2020

Motivation for this change

https://metacpan.org/release/SKAJI/App-cpm-0.996

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner December 7, 2020 04:06
stigtsp
stigtsp approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested cpm install Smart::Comments OK on linux x64

Result of nixpkgs-review pr 106134 run on x86_64-linux 1

2 packages built:
  • perl530Packages.Appcpm
  • perl532Packages.Appcpm

@stigtsp stigtsp merged commit 732cc5c into NixOS:master Dec 7, 2020
@zakame
Copy link
Member Author

zakame commented Dec 7, 2020

Thanks! 🎉

@zakame zakame deleted the updates/perl-App-cpm-0.996 branch December 7, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakame @stigtsp