Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer: 1.18.1 -> 1.18.2 #106124

Merged
merged 1 commit into from Dec 17, 2020
Merged

gstreamer: 1.18.1 -> 1.18.2 #106124

merged 1 commit into from Dec 17, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Dec 7, 2020

Motivation for this change

https://gstreamer.freedesktop.org/releases/1.18/
(scroll to the bottom)

Things done

Tested with #106044 cherrypicked, otherwise it doesn't build.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Did you forget to commit the version bump?

@lukegb
Copy link
Contributor Author

lukegb commented Dec 7, 2020

Did you forget to commit the version bump?

squints how did I manage that. Oops.

@FRidh
Copy link
Member

FRidh commented Dec 8, 2020

Waiting for #106044.

@FRidh FRidh added this to WIP in Staging via automation Dec 8, 2020
@SuperSandro2000
Copy link
Member

#106044 is merged.

@FRidh FRidh merged commit 68fdbc6 into NixOS:staging Dec 17, 2020
Staging automation moved this from WIP to Done Dec 17, 2020
@lukegb lukegb deleted the gstreamer-1.18.2 branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @SuperSandro2000 @FRidh