Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add package wayfire. #106129

Closed
wants to merge 10 commits into from
Closed

[WIP] Add package wayfire. #106129

wants to merge 10 commits into from

Conversation

ishan9299
Copy link

Motivation for this change

Wayfire is a wayland compositor. The wayfire package itself is available as package in nixpkgs-overlays repo but it doesn't have the packages required to give us the gui desktop. So this pull request was made. Also if possible we can have modules for wayfire like sway or gnome3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ishan9299
Copy link
Author

I am using the wlroots in the submodule because wayfire isn't compatible with wlroots in nixpkgs. So we can create a specific version of wlroots for wayfire or use the submodule.

@ishan9299 ishan9299 changed the title Add package wayfire. [WIP] Add package wayfire. Dec 7, 2020
@ishan9299
Copy link
Author

I am now using wlroots from nixpkgs for building wayfire.

@ishan9299 ishan9299 closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ishan9299 @orivej @mingmingrr