Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hoist-error: not broken #106130

Merged
merged 1 commit into from Dec 7, 2020
Merged

haskellPackages.hoist-error: not broken #106130

merged 1 commit into from Dec 7, 2020

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Dec 7, 2020

Motivation for this change

hoist-error builds on my machine

Things done

NIXPKGS_ALLOW_BROKEN=1 nix-build --no-out-link -A haskellPackages.hoist-error

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame
Copy link
Contributor Author

endgame commented Dec 7, 2020

Hopefully this is going to the right branch. Will rebase if not.

@cdepillabout
Copy link
Member

Looks good, thanks!

@cdepillabout cdepillabout merged commit c4aa299 into NixOS:haskell-updates Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endgame @cdepillabout