Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/docker-tools.nix: "Fix" format #105662

Merged
merged 1 commit into from Dec 2, 2020
Merged

nixos/tests/docker-tools.nix: "Fix" format #105662

merged 1 commit into from Dec 2, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Dec 2, 2020 •
edited

docker-tools test hasn't been running for a while due to a formatting error.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from roberth as a code owner December 2, 2020 07:05
@srhb
Copy link
Contributor Author

srhb commented Dec 2, 2020

@ofborg test docker-tools

@roberth
Copy link
Member

roberth commented Dec 2, 2020

Thanks!
Long term we need #72964. This is just busywork.

@roberth roberth merged commit 54ec506 into NixOS:master Dec 2, 2020
@roberth roberth changed the title nixos/tests/docker-tools.nix: Fix format nixos/tests/docker-tools.nix: "Fix" format Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth Awaiting requested review from roberth roberth is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @roberth