Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cfn-lint: 0.35.1 -> 0.42.0 #105658

Merged
merged 1 commit into from Jan 1, 2021
Merged

pythonPackages.cfn-lint: 0.35.1 -> 0.42.0 #105658

merged 1 commit into from Jan 1, 2021

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Dec 2, 2020

Motivation for this change

Update cfn-lint

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame
Copy link
Contributor Author

endgame commented Dec 2, 2020

Why does ofbog think this will cause such a large rebuild? Did I do something wrong?

@jonringer
Copy link
Contributor

Why does ofbog think this will cause such a large rebuild? Did I do something wrong?

It's the number of packages which directly or indirectly conusme this package

@jonringer
Copy link
Contributor

jonringer commented Dec 2, 2020 •
edited

may want to wait til after #105584 gets merged, currently a lot of noise with review

@endgame
Copy link
Contributor Author

endgame commented Dec 2, 2020

All right. I've subscribed to #105584 and will rebase and make noise after that merges.

@endgame endgame marked this pull request as draft December 2, 2020 08:11
@rmcgibbo
Copy link
Contributor

It looks like the existing python3{7,8,9}Packages.cfn-lint started to crash on hydra last night (https://hydra.nixos.org/job/nixpkgs/trunk/python38Packages.cfn-lint.x86_64-linux), which is blocking all of the downstream dependencies, so it might be a good idea to get this upgrade in.

@endgame endgame marked this pull request as ready for review January 1, 2021 07:58
@endgame
Copy link
Contributor Author

endgame commented Jan 1, 2021

Rebased on latest master. Let's see if that gets the rebuild count down...

@SuperSandro2000
Copy link
Member

Rebased on latest master. Let's see if that gets the rebuild count down...

It won't and rebasing is normally not required.

@SuperSandro2000
Copy link
Member

I am going to fix this PR and pushing it in a few minutes cause this is causing build failures in a lot of other PRs.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 1, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit 8925945 into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endgame @jonringer @rmcgibbo @SuperSandro2000