Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

q-text-as-data: 1.7.4 -> 2.0.19 #105681

Merged
merged 1 commit into from Dec 11, 2020
Merged

q-text-as-data: 1.7.4 -> 2.0.19 #105681

merged 1 commit into from Dec 11, 2020

Conversation

avdv
Copy link
Member

@avdv avdv commented Dec 2, 2020

Motivation for this change

Version 1.7.4 is already quite old...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Taneb December 2, 2020 10:45
Taneb
Taneb reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@Taneb Taneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It looks great 🥰

I'll give it a test when I get a minute

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105681 run on x86_64-linux 1

1 package built:
  • q-text-as-data

@SuperSandro2000
Copy link
Member

Please disable the tests and add an pythonImportsCheck.

q-text-as-data.log                                                                                                                                                                          115:Ran 0 tests in 0.000s

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105681 run on x86_64-darwin 1

1 package built:
  • q-text-as-data

@avdv
Copy link
Member Author

avdv commented Dec 2, 2020 •
edited

Please disable the tests and add an pythonImportsCheck.

I disabled the tests with doCheck = false;, but there is no module to import as this thing is just one big python file...

@ofborg ofborg bot requested a review from Taneb December 2, 2020 21:37
@avdv
Copy link
Member Author

avdv commented Dec 9, 2020

@SuperSandro2000 anything left to do here?

@SuperSandro2000 SuperSandro2000 merged commit f011612 into NixOS:master Dec 11, 2020
@avdv avdv deleted the q-text-as-data-2.0.19 branch December 11, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taneb Taneb Taneb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avdv @SuperSandro2000 @Taneb