pianobooster: Fix 'Could not find the Qt platform plugin "xcb" in ""' for #105663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannahusum
changed the title
drewrisinger
suggested changes
Dec 3, 2020
There was a problem hiding this comment.
Hi @mannahusum! Thanks for your first contribution! This is mostly correct, but there's a few minor problems with it that we need to address:
- This targets the
release-20.09branch directly. Standard practice is to commit tomasterbranch first and then backport it torelease-20.09(see the Contributing document, basicallygit checkout -b fix-pianobooster release-20.09in a new pull request. - Assuming that this was on the correct branch, the below change would need to be made to the diff to match standard conventions
- You might be able to keep this PR and make it meet our conventions by running
git rebase --interactive masterand deleting everything except the pianobooster commit. Then push & change the target branch at the top of this PR screen. If you don't want to/can't figure out how to do that, close this PR, open a new one with the correct git branching etc, then tag me in it & I'll follow up.
Standard checklist:
- Diff mostly LGTM
- Commits: targets
release-20.09branch when it shouldn't, extra pull commit - Builds via
nix-review, don't see missing xcb (can't fully start b/c I'm running on a headless machine).
https://github.com/NixOS/nixpkgs/pull/105663
1 package built:
pianobooster
$ nix-shell ~/.cache/nixpkgs-review/pr-105663/shell.nix
[nix-shell:~/.cache/nixpkgs-review/pr-105663]$ pianobooster
qt.qpa.xcb: could not connect to display 172.27.64.1:0.0
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Comment on lines
+2
to
+3
| , alsaLib, ftgl, libGLU, libjack2, qtbase, rtmidi, | ||
| mkDerivation |
There was a problem hiding this comment.
Suggested change
| , alsaLib, ftgl, libGLU, libjack2, qtbase, rtmidi, | |
| mkDerivation | |
| , alsaLib, ftgl, libGLU, libjack2, qtbase, rtmidi | |
| , mkDerivation |
This fits convention better
|
I will reopen it as a pull request to master including the changes mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Installing and running pianobooster from nixpkgs currently gives the error:
Could not find the Qt platform plugin "xcb" in ""
Things done
Fixed mkDerviation according to #65399
Just executed it afterwards, and it works
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)