Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.11.1 -> 1.12.0 #105679

Merged
merged 1 commit into from Dec 2, 2020
Merged

syncthing: 1.11.1 -> 1.12.0 #105679

merged 1 commit into from Dec 2, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 2, 2020

Motivation for this change

https://github.com/syncthing/syncthing/releases/tag/v1.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg test syncthing

jonringer
jonringer approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests pass

https://github.com/NixOS/nixpkgs/pull/105679
5 packages built:
qsyncthingtray syncthing syncthing-cli syncthing-discovery syncthing-relay

$ nix-shell /home/jon/.cache/nixpkgs-review/pr-105679-1/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-105679-1]$ nix build -f ./nixpkgs/ nixosTests.syncthing
[47 built, 9 copied (265.9 MiB), 21.2 MiB DL]

@jonringer jonringer merged commit 8eb28a1 into NixOS:master Dec 2, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105679 run on x86_64-darwin 1

1 package failed to build:
  • qsyncthingtray
4 packages built:
  • syncthing
  • syncthing-cli
  • syncthing-discovery
  • syncthing-relay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@kalbasit kalbasit Awaiting requested review from kalbasit

@andrew-d andrew-d Awaiting requested review from andrew-d

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @jonringer @SuperSandro2000