Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdftk: mark broken on darwin #105673

Merged
merged 1 commit into from Dec 2, 2020
Merged

pdftk: mark broken on darwin #105673

merged 1 commit into from Dec 2, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#105458 (comment)

@primeos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Dec 2, 2020
primeos
primeos approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be better to mark gradle_6 as broken on Darwin (if that's the case) but I'm fine with it either way.

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 105673 run on x86_64-darwin 1

@SuperSandro2000 SuperSandro2000 merged commit 16c6188 into NixOS:master Dec 2, 2020
@SuperSandro2000 SuperSandro2000 deleted the pdftk-darwin branch December 2, 2020 18:49
@xworld21 xworld21 mentioned this pull request Apr 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @primeos