Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] sqlite: 3.33.0 -> 3.34.0 #105670

Merged
merged 2 commits into from Dec 8, 2020
Merged

[staging] sqlite: 3.33.0 -> 3.34.0 #105670

merged 2 commits into from Dec 8, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@mweinelt mweinelt added this to WIP in Staging via automation Dec 3, 2020
@jonringer jonringer changed the title sqlite: 3.33.0 -> 3.34.0 [staging] sqlite: 3.33.0 -> 3.34.0 Dec 8, 2020
@FRidh
Copy link
Member

FRidh commented Dec 8, 2020

sqlalchemy built successfully

@FRidh FRidh merged commit b7a700e into NixOS:staging Dec 8, 2020
Staging automation moved this from WIP to Done Dec 8, 2020
@zowoq zowoq deleted the sqlite branch December 8, 2020 07:43
@jonringer
Copy link
Contributor

doesn't look like any breaking changes
https://www.sqlite.org/changes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

@np np Awaiting requested review from np

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @FRidh @jonringer @SuperSandro2000