Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.qtwebengine: remove patch upstreamed in 5.12.2 #106749

Merged
merged 1 commit into from Dec 12, 2020
Merged

qt5.qtwebengine: remove patch upstreamed in 5.12.2 #106749

merged 1 commit into from Dec 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2020

Motivation for this change

QtWebEngine build was failing on staging

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from ttuegel as a code owner December 12, 2020 14:53
@ghost ghost requested review from FRidh and andir December 12, 2020 18:06
@FRidh FRidh merged commit aa81ee8 into NixOS:staging Dec 12, 2020
@ttuegel
Copy link
Member

ttuegel commented Dec 12, 2020

I'm sorry, I thought it built for me locally. That's so weird! 🤔

@ghost
Copy link
Author

ghost commented Dec 12, 2020

I'm sorry, I thought it built for me locally. That's so weird!

Oh no you didn't break it, this patch was added on master (where it was required because 5.15.0) and the automatic merge added it to staging as well 😄

@ghost ghost deleted the feature/fix-qtwebengine-staging branch December 12, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@FRidh FRidh Awaiting requested review from FRidh

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @FRidh