Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalameta: 1.9.7 -> 1.9.9 #106747

Closed
wants to merge 1 commit into from

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Dec 12, 2020

Motivation for this change

This version of scalameta supports scala 3.0.0-M2 which again supports Scala.js, so this is a big improvement. I have used it locally for several days, it has worked without any problems. All in all, this should just be a simple upgrade.

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@scalavision
Copy link
Contributor Author

This can be closed, I am working on a new update to 1.9.10, that will be PR'd in just a moment.

@prusnak prusnak closed this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants