Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tensorflow_2: relax h5py dependency #106769

Merged
merged 1 commit into from Dec 13, 2020
Merged

python3Packages.tensorflow_2: relax h5py dependency #106769

merged 1 commit into from Dec 13, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

Relaxes the h5py dependency pin to fix the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt mentioned this pull request Dec 12, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from abbradar December 12, 2020 18:03
@mweinelt
Copy link
Member Author

Tested using tts and working.

@mweinelt mweinelt merged commit 2e2b724 into NixOS:master Dec 13, 2020
@mweinelt mweinelt deleted the tensorflow branch December 13, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mweinelt