Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broadcom: fix build 5.9 #106760

Merged
merged 2 commits into from Dec 30, 2020
Merged

broadcom: fix build 5.9 #106760

merged 2 commits into from Dec 30, 2020

Conversation

SebastienWae
Copy link
Contributor

Motivation for this change

Patch to fix the build error for the 5.9 Linux kernel.
Related to github:nixos/nixpkgs#101040

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Phreedom December 12, 2020 16:50
@SebastienWae
broadcom: fix build 5.9
c8dc527 
Patch to fix the build error for the 5.9 Linux kernel.
@SebastienWae
broadcom: swith 5.9 patch to Joan Bruguera's version
26ff2b6 
Switch the current patch for 5.9 to Joan Bruguera's version which is cleaner and also works for 5.10
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/414

@SebastienWae
Copy link
Contributor Author

@teto pinging you since you were the last one to submit a patch for broadcom-sta. Hopefully you still have a machine to test it.

@teto
Copy link
Member

teto commented Dec 30, 2020

upstream is dead for this broadcom stuff which explains why we have so many issues :(
My machine with the broadcom died so can't test but the patch looks ok. See https://gist.github.com/joanbm/9e20b3842bb336379eccc12410901e37 for some context.

@teto teto merged commit e8dd1fa into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SebastienWae @nixos-discourse @teto @Janik-Haag