Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element-desktop: associate with element:// links #106750

Merged
merged 1 commit into from Dec 12, 2020
Merged

element-desktop: associate with element:// links #106750

merged 1 commit into from Dec 12, 2020

Conversation

sephii
Copy link
Contributor

@sephii sephii commented Dec 12, 2020

Motivation for this change

element-web is currently not configured to open element:// links, which makes it impossible to use it with SSO. Here’s a similar bug report with a fix on Arch Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog
Copy link
Member

Ekleog commented Dec 12, 2020

LGTM, thank you! Merging based on discussion around element-hq/element-web#12830 :)

@Ekleog Ekleog merged commit 3043fe5 into NixOS:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguentner mguentner Awaiting requested review from mguentner

@Ekleog Ekleog Awaiting requested review from Ekleog

@fadenb fadenb Awaiting requested review from fadenb

@pacien pacien Awaiting requested review from pacien

@Ralith Ralith Awaiting requested review from Ralith

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sephii @Ekleog