qbittorrent: extending path to include Python3 for default functionality #106735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
changed the title
|
@GrahamcOfBorg build qbittorrent |
|
is it not compatible with |
|
Oh, yes, the naming. |
Anton-Latukha
force-pushed
the
2020-12-12-extend-qbittorrent-path
branch
from
ed32615
to
755432f
Compare
|
Done. |
Anton-Latukha
changed the title
ghost
suggested changes
Dec 19, 2020
There was a problem hiding this comment.
The first two commits look good, I tested the search function and it worked as expected. The last commit looks a bit odd to me:
[pbb@onyx:~/proj/nixpkgs]$ tree result/
result
├── bin
│ └── qbittorrent
└── share
├── applications
│ └── org.qbittorrent.qBittorrent.desktop
├── icons
[...]
├── metainfo
│ └── org.qbittorrent.qBittorrent.appdata.xml
└── pixmaps
└── qbittorrent.png
[pbb@onyx:~/proj/nixpkgs]$ tree result-dev/
result-dev
└── nix-support
└── propagated-build-inputs
[pbb@onyx:~/proj/nixpkgs]$ tree result-bin/
result-bin
└── share
└── man
└── man1
└── qbittorrent.1.gz
[pbb@onyx:~/proj/nixpkgs]$
But only the bin output would be installed to a profile, so no binary or .desktop file would be available.
Maybe you can move the last commit to its own PR so we can merge the rest.
Since people regularly open reports about tracker search not working because python is not found. And since Tracker Search in qBittorrent can not be disabled & at the same time the Pythong is needed for it to work - including Python for default functionality to work.
Anton-Latukha
force-pushed
the
2020-12-12-extend-qbittorrent-path
branch
from
755432f
to
b951431
Compare
|
Rebased to Removed the last commit of split outputs. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since people regularly open reports about tracker search not working because
pythonis not found. The most recent of reports/discussions being #104221.And since Tracker Search in qBittorrent can not be disabled & at the same time
the Python is needed for it to work - including Python for default
functionality to work.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"(no dependent packages)
./result/bin/)nix path-info -Sbefore and after)