Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mindforger: 1.48.2 -> 1.52.0 #106741

Merged
merged 1 commit into from Jan 1, 2021
Merged

mindforger: 1.48.2 -> 1.52.0 #106741

merged 1 commit into from Jan 1, 2021

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented Dec 12, 2020

Motivation for this change
  • new upstream version
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • tested under i3:
      • fresh app start
      • creating new repository with default content
      • opening an existing repository
      • restart (app opens up previously opened repository by default)
      • navigation using keyboard shortcuts
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyplo
Copy link
Contributor Author

cyplo commented Dec 12, 2020

@s9gf4ult if you could take a look that would be grand

@cyplo
Copy link
Contributor Author

cyplo commented Dec 21, 2020

@Staberinde could you try testing on yours as well, I can see you got excited by the PR :)

@Staberinde
Copy link

Haha, I'll see what I can do

@cyplo
Copy link
Contributor Author

cyplo commented Dec 29, 2020

thanks @SuperSandro2000 , if you could take another look :)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106741 run on x86_64-linux 1

1 package built:
  • mindforger

@SuperSandro2000
Copy link
Member

Building on darwin is fixed by #107898

@cyplo
Copy link
Contributor Author

cyplo commented Dec 30, 2020

@SuperSandro2000 if you could take another look, seems fine now on my end at least :) thanks !

@SuperSandro2000 SuperSandro2000 merged commit e5c488c into NixOS:master Jan 1, 2021
@cyplo cyplo deleted the mindforger1.52 branch January 1, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s9gf4ult s9gf4ult s9gf4ult approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyplo @Staberinde @SuperSandro2000 @s9gf4ult