Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoptopenjdk: set CLASSPATH #106737

Merged
merged 1 commit into from May 3, 2021
Merged

adoptopenjdk: set CLASSPATH #106737

merged 1 commit into from May 3, 2021

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Dec 12, 2020

Motivation for this change

Other JDK packages set CLASSPATH via setJavaClassPath.

See: #106716.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0 taku0 mentioned this pull request Dec 13, 2020
Open
13 tasks
@SuperSandro2000
Copy link
Member

/rebase-staging

@github-actions github-actions bot changed the base branch from master to staging January 18, 2021 19:34
raboof
raboof approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Tested with nix-shell -p adoptopenjdk-bin macse -I nixpkgs=... --run "export | grep CLASSP" that this indeed has the desired effect.

This branch is conflicting with the staging branch, though, so it'll need a rebase. After that LGTM.

@taku0
Copy link
Contributor Author

taku0 commented May 2, 2021

Thank you for reviewing. Rebased and resolved the conflicts.

@raboof raboof merged commit afdee7e into NixOS:staging May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @SuperSandro2000 @raboof