Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

biboumi: 8.5 -> 9.0 #106765

Merged
merged 1 commit into from Feb 25, 2021
Merged

biboumi: 8.5 -> 9.0 #106765

merged 1 commit into from Feb 25, 2021

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Dec 12, 2020

Motivation for this change

Update to latest release of biboumi

Things done
  • update version and sha256 attributes.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from woffs December 12, 2020 17:14
@woffs
Copy link
Contributor

woffs commented Dec 14, 2020

Manpage is missing. It was there before (with 8.5).

@woffs
Copy link
Contributor

woffs commented Dec 19, 2020

Thank you!

@ofborg ofborg bot requested a review from woffs December 20, 2020 02:21
@ju1m
Copy link
Contributor Author

ju1m commented Jan 18, 2021

Rebased after 4a7f99d changed stdenv.lib to lib.

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 106765 run on x86_64-linux 1

1 package built:
  • biboumi

@tomberek tomberek merged commit a98ed9e into NixOS:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woffs woffs Awaiting requested review from woffs

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ju1m @woffs @tomberek