Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gqrx: fix icon #106466

Merged
merged 1 commit into from Dec 9, 2020
Merged

gqrx: fix icon #106466

merged 1 commit into from Dec 9, 2020

Conversation

eduardosm
Copy link
Contributor

Motivation for this change

The icon is a single file, so it should be placed in pixmaps instead of icons.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eduardosm
gqrx: fix icon
57a8558 
The icon is a single file, so it should be placed in `pixmaps` instead of `icons`.
@ofborg ofborg bot requested review from bjornfor and fpletz December 9, 2020 17:07
@bjornfor bjornfor merged commit 2959bb7 into NixOS:master Dec 9, 2020
@eduardosm eduardosm deleted the gqrx branch December 9, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduardosm @bjornfor