Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluxcd: init at 0.5.0 #106483

Merged
merged 1 commit into from Dec 12, 2020
Merged

fluxcd: init at 0.5.0 #106483

merged 1 commit into from Dec 12, 2020

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Add fluxcd

This is flux v2. There is also fluxctl (flux v1). v1 is in maintenance
mode, and it will be deprecated at some point, but some people may still
depend on v1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit December 9, 2020 20:27
@jlesquembre
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 11, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 11, 2020

@glittershark please review.

@jlesquembre
fluxcd: init at 0.5.0
e10a0ae 
This is flux v2. There is also fluxctl (flux v1). v1 is in maintenance
mode, and it will be deprecated at some point, but some people may still
depend on v1.
@jlesquembre jlesquembre changed the title fluxcd: init at 0.4.3 fluxcd: init at 0.5.0 Dec 11, 2020
@glittershark
Copy link
Member

Result of nixpkgs-review pr 106483 1

1 package built:
  • fluxcd

@glittershark
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau December 12, 2020 00:19
timokau
timokau approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to both of you :)

@timokau timokau merged commit 13bfaa4 into NixOS:master Dec 12, 2020
@jlesquembre jlesquembre deleted the fluxcd branch January 7, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glittershark glittershark glittershark left review comments

@timokau timokau timokau approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Gonzih Gonzih Awaiting requested review from Gonzih

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @glittershark @timokau