Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad_1_0: init at 1.0.1 #106454

Merged
merged 1 commit into from Dec 22, 2020
Merged

nomad_1_0: init at 1.0.1 #106454

merged 1 commit into from Dec 22, 2020

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Dec 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106454 run on x86_64-linux 1

1 package built:
  • nomad_1_0

@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 11, 2020

I've added the commit hashicorp/nomad@6bfbadc as a patch, otherwise a big value-add for nomad 1.0 is missing.

@ofborg ofborg bot requested a review from endocrimes December 11, 2020 23:44
endocrimes
endocrimes reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nomad 1.0.0 inclusion lgtm, other stuff is pending.

pkgs/applications/networking/cluster/nomad/generic.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/nomad/1.0.nix Outdated Show resolved Hide resolved
@cpcloud cpcloud changed the title nomad: 0.12 -> 1.0.0 nomad: 0.12 -> 1.0.1 Dec 17, 2020
Mic92
Mic92 reviewed Dec 17, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -6046,6 +6046,9 @@ in
nomad_0_12 = callPackage ../applications/networking/cluster/nomad/0.12.nix {
buildGoPackage = buildGo114Package;
};
nomad_1_0 = callPackage ../applications/networking/cluster/nomad/1.0.nix {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many versions of nomad do we need to keep?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 ~roughly speaking N-1, N, N+1, where N is the last stable release (typically around the third patch release for a version is where I'd call them stable)

@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 18, 2020

@Mic92 @endocrimes Can this be merged?

endocrimes
endocrimes approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106454 run on x86_64-linux 1

1 package built:
  • nomad_1_0

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 19, 2020 •
edited

Can you please change the title and the commit message to: nomad_1_0: init at 1.0.1.

@cpcloud cpcloud changed the title nomad: 0.12 -> 1.0.1 nomad_1_0: init at 1.0.1 Dec 21, 2020
@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 21, 2020

@SuperSandro2000 Done!

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106454 run on x86_64-darwin 1

1 package built:
  • nomad_1_0

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106454 run on x86_64-linux 1

1 package built:
  • nomad_1_0

@SuperSandro2000 SuperSandro2000 merged commit 6411d74 into NixOS:master Dec 22, 2020
@cpcloud cpcloud deleted the nomad-one-point-oh branch December 23, 2020 12:27
@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 23, 2020

Thanks @SuperSandro2000!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@amaxine amaxine amaxine left review comments

@endocrimes endocrimes endocrimes approved these changes

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpcloud @SuperSandro2000 @Mic92 @endocrimes @amaxine