Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitwig-studio3: 3.2.8 -> 3.3 #106460

Closed
wants to merge 2 commits into from
Closed

bitwig-studio3: 3.2.8 -> 3.3 #106460

wants to merge 2 commits into from

Conversation

sorooris
Copy link

@sorooris sorooris commented Dec 9, 2020 •
edited

Motivation for this change

Updates Bitwig Studio 3 to its latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from mrVanDalo and michalrus December 9, 2020 16:10
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 9, 2020 •
edited

Please change the commit message to bitwig-studio3: 3.2.8 -> 3.3.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106460 run on x86_64-linux 1

1 package built:
  • bitwig-studio (bitwig-studio3)

bitwig-studio3: 3.2.8 -> 3.3
f1c0c72 
Updates Bitwig Studio 3 to its latest version.
@sorooris
Copy link
Author

sorry for the delay, fixed

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106460 run on x86_64-linux 1

1 package failed to build:
  • bitwig-studio (bitwig-studio3)

I think the build times out.

@bfortz
Copy link
Contributor

bfortz commented Dec 23, 2020

I tried to bump to 3.3.1 while I was at it, there are several issues, build fails because of the libxkbcommon trick in bitwig-studio1. libxkbcommon.so is now dynamically linked, and the postFxup phase is not needed anymore. Once this is changed, the build succeeds but it cannot start the audio engine. BitwigStudioEngine seg faults and ldd BitwigStudioEngine does not report anything. My guess is that thy bumped alsa-libs to 1.2.4, I'm trying to upgrade now. Keep tuned...

@bfortz
Copy link
Contributor

bfortz commented Dec 26, 2020

The problem was not static linking, but patchelf corrupting the ELF file. Fixed in #107630.

@bfortz bfortz closed this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrVanDalo mrVanDalo Awaiting requested review from mrVanDalo

@michalrus michalrus Awaiting requested review from michalrus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sorooris @SuperSandro2000 @bfortz @Janik-Haag