Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.73.0 -> 7.74.0 #106452

Merged
merged 1 commit into from Dec 11, 2020
Merged

curl: 7.73.0 -> 7.74.0 #106452

merged 1 commit into from Dec 11, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 9, 2020

Motivation for this change

https://curl.se/docs/CVE-2020-8284.html
https://curl.se/docs/CVE-2020-8285.html
https://curl.se/docs/CVE-2020-8286.html

Fixes: CVE-2020-8284, CVE-2020-8285, CVE-2020-8286

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 9, 2020
@mweinelt mweinelt added this to WIP in Staging via automation Dec 9, 2020
@mweinelt mweinelt moved this from WIP to Needs review in Staging Dec 9, 2020
@FRidh
Copy link
Member

FRidh commented Dec 9, 2020

If these are not critical, staging is the correct branch.

TredwellGit
TredwellGit approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@TredwellGit TredwellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt my personal system with this.

@mweinelt mweinelt merged commit 4c5d46c into NixOS:staging Dec 11, 2020
Staging automation moved this from Needs review to Done Dec 11, 2020
@mweinelt mweinelt deleted the curl branch December 11, 2020 17:31
@mweinelt mweinelt mentioned this pull request Dec 11, 2020
Merged
10 tasks
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TredwellGit TredwellGit TredwellGit approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @FRidh @TredwellGit @erictapen