Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diylc: init at 4.15.1 #106456

Merged
merged 1 commit into from Jan 7, 2021
Merged

diylc: init at 4.15.1 #106456

merged 1 commit into from Jan 7, 2021

Conversation

eduardosm
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits together.

@eduardosm
Copy link
Contributor Author

Please squash the commits together.

Done

@eduardosm eduardosm changed the title diylc: init at 4.11.0 diylc: init at 4.12.0 Dec 13, 2020
@eduardosm
Copy link
Contributor Author

Updated to 4.12.0

@eduardosm eduardosm changed the title diylc: init at 4.12.0 diylc: init at 4.13.0 Dec 23, 2020
@eduardosm eduardosm changed the title diylc: init at 4.13.0 diylc: init at 4.14.0 Dec 31, 2020
@eduardosm eduardosm changed the title diylc: init at 4.14.0 diylc: init at 4.15.1 Jan 6, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/432

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106456 run on x86_64-linux 1

1 package built:
  • diylc

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106456 run on x86_64-linux 1

1 package built:
  • diylc

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit ec56bf6 into NixOS:master Jan 7, 2021
@eduardosm eduardosm deleted the diylc branch January 7, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eduardosm @nixos-discourse @SuperSandro2000