Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: 4.0.6 -> 4.0.7 #106459

Merged
merged 1 commit into from Dec 10, 2020
Merged

electrum: 4.0.6 -> 4.0.7 #106459

merged 1 commit into from Dec 10, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 9, 2020 •
edited

Version update - release notes: https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

This release also fixes compatibility with dnspython 2.x, so we can drop the overrides

Also cryptography is required instead of pycryptodomex (which is required only for tests now) and ecdsa dependency is dropped completely

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ehmry, joachifm and np December 9, 2020 16:10
drewrisinger
drewrisinger approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
https://github.com/NixOS/nixpkgs/pull/106459
1 package built:
electrum

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106459 run on x86_64-linux 1

1 package built:
  • electrum

@SuperSandro2000
Copy link
Member

Fails on darwin with:

                    except OSError as err:                                                                                                                                                  >                       raise OSError(err.errno, 'error while attempting '                                                                                                                                                        'to bind on address %r: %s'                                                                                                                                                                 % (sa, err.strerror.lower())) from None                                                                                                               E                                     PermissionError: [Errno 1] error while attempting to bind on address ('127.0.0.1', 42898): operation not permitted                                                                                                                                                                                                                                /nix/store/cwrsy4lr71pbs89krkfcwb3s4amc3rjg-python3-3.8.6/lib/python3.8/asyncio/base_events.py:1463: PermissionError                                                                        --------------------------- Captured stderr teardown --------------------------

....

electrum/tests/test_network.py::TestNetwork::test_can_connect_during_backward
electrum/tests/test_network.py::TestNetwork::test_chain_false_during_binary
electrum/tests/test_network.py::TestNetwork::test_fork_conflict
electrum/tests/test_network.py::TestNetwork::test_fork_noconflict
  /nix/store/cwrsy4lr71pbs89krkfcwb3s4amc3rjg-python3-3.8.6/lib/python3.8/asyncio/events.py:81: RuntimeWarning: coroutine 'ignore_exceptions.<locals>.wrapper' was never awaited
    self._context.run(self._callback, *self._args)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info ============================
FAILED electrum/tests/test_lntransport.py::TestLNTransport::test_loop - Permi...
============ 1 failed, 502 passed, 3 skipped, 4 warnings in 39.40s =============
--- Logging error ---
Traceback (most recent call last):
  File "/nix/store/cwrsy4lr71pbs89krkfcwb3s4amc3rjg-python3-3.8.6/lib/python3.8/logging/__init__.py", line 1084, in emit
    stream.write(msg + self.terminator)
ValueError: I/O operation on closed file.
Call stack:
  File "/nix/store/cwrsy4lr71pbs89krkfcwb3s4amc3rjg-python3-3.8.6/lib/python3.8/threading.py", line 890, in _bootstrap
    self._bootstrap_inner()
  File "/nix/store/cwrsy4lr71pbs89krkfcwb3s4amc3rjg-python3-3.8.6/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/private/tmp/nix-build-electrum-4.0.7.drv-0/Electrum-4.0.7/electrum/plugin.py", line 214, in run
    self.on_stop()
  File "/private/tmp/nix-build-electrum-4.0.7.drv-0/Electrum-4.0.7/electrum/util.py", line 357, in on_stop
    self.logger.info("stopped")
Message: 'stopped'
Arguments: ()

@prusnak
electrum: 4.0.6 -> 4.0.7
16b38b0 
this release also fixes compatibility with dnspython 2.x,
so we can drop the overrides

also cryptography is required instead of pycryptodomex
(which is required only for tests now) and ecdsa dependency
is dropped completely
@prusnak
Copy link
Member Author

prusnak commented Dec 9, 2020

Fails on darwin with:

Disabled the offending test in 16b38b0

@prusnak prusnak merged commit 1183f62 into NixOS:master Dec 10, 2020
@prusnak prusnak deleted the electrum branch December 10, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

@joachifm joachifm Awaiting requested review from joachifm

@np np Awaiting requested review from np

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @SuperSandro2000 @ehmry @drewrisinger