Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: 2.1.0 -> 2.2.0 #105558

Merged
merged 1 commit into from Dec 1, 2020
Merged

podman: 2.1.0 -> 2.2.0 #105558

merged 1 commit into from Dec 1, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Dec 1, 2020 •
edited

Motivation for this change

Update podman to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/podman

vdemeester
vdemeester approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@SuperSandro2000
Copy link
Member

Would you mind looking at the ofborg test which did not succeed? Not sure if this update caused the failure.

https://logs.nix.ci/?key=nixos/nixpkgs.105558&attempt_id=2cfef087-d2ec-40ac-9ca8-3a9dbb571f63

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105558 run on x86_64-linux 1

2 packages built:
  • podman
  • podman-unwrapped

@lukegb
Copy link
Contributor

lukegb commented Dec 1, 2020

@ofborg build
@ofborg test podman

@saschagrunert
Copy link
Member Author

It looks like that all rootless tests are broken, not sure why yet.

@saschagrunert @adisbladis
podman: 2.1.0 -> 2.2.0
074dd0a 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@adisbladis
Copy link
Member

@saschagrunert I took the liberty of fixing up the test and pushing.

saschagrunert
saschagrunert commented Dec 1, 2020
View reviewed changes
nixos/tests/podman.nix
Comment on lines +65 to +67
podman.succeed(
"mkdir -p /tmp/podman-run-1000/libpod && chown alice -R /tmp/podman-run-1000"
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adisbladis! 🙏 I'm wondering if this is a Podman regression and there is a missing mkdirAll somewhere in the code base.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't debugged this in detail, but an educated guess is that it stems from us not executing commands from the context of a proper systemd user session where these directories would have been created at login time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@saschagrunert
Copy link
Member Author

@saschagrunert I took the liberty of fixing up the test and pushing.

Awesome, thank you! 🙏

@saschagrunert
Copy link
Member Author

@ofborg test podman

@ofborg ofborg bot added the 6.topic: nixos label Dec 1, 2020
@ofborg ofborg bot requested a review from vdemeester December 1, 2020 11:56
@zowoq zowoq merged commit bd6067c into NixOS:master Dec 1, 2020
@saschagrunert saschagrunert deleted the podman branch December 1, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq Awaiting requested review from zowoq

@adisbladis adisbladis Awaiting requested review from adisbladis

@marsam marsam Awaiting requested review from marsam

@kalbasit kalbasit Awaiting requested review from kalbasit

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @SuperSandro2000 @lukegb @adisbladis @vdemeester @zowoq