Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vampire: update license to BSD-3 Clause. #105528

Closed
wants to merge 1 commit into from
Closed

vampire: update license to BSD-3 Clause. #105528

wants to merge 1 commit into from

Conversation

elliottvillars
Copy link
Contributor

As of November 2020, Vampire now uses a modified BSD-3 license.

Motivation for this change

As of November 2020, Vampire now uses a modified BSD-3 license.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elliottvillars
vampire: update license to BSD-3 Clause.
776e426 
As of November 2020, Vampire now uses a modified BSD-3 license.
@lukegb
Copy link
Contributor

lukegb commented Dec 1, 2020

Can this wait for the next upstream release? I'm uncomfortable with changing the license to something which isn't in the repo at the tag we're actually using it at.

@SuperSandro2000
Copy link
Member

I'm uncomfortable with changing the license to something which isn't in the repo at the tag we're actually using it at.

The current release should still be the old license, right? This should be definitely be changed for the next update.

@mweinelt
Copy link
Member

mweinelt commented Dec 1, 2020 •
edited

As previously mentioned, the issue is that at the version (4.5.1) we have in nixpkgs the license looks like this: https://github.com/vprover/vampire/blob/57a6f78cc2bc179e480c3d47d09fbfc1ec8d1f23/LICENCE (sic!)

Please ask the upstream to release a new version, so distros can package that under the new license.

@elliottvillars
Copy link
Contributor Author

Alright, I'll close this.

@lukegb lukegb mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elliottvillars @lukegb @SuperSandro2000 @mweinelt