Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools: 47.3.1 -> 50.3.2 #105548

Closed
wants to merge 1 commit into from
Closed

setuptools: 47.3.1 -> 50.3.2 #105548

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 1, 2020

reveals there's upstream work to be done for reproducibility

perhaps we should update anyway (without the tar changes) so at least the jump is smaller when we do update upstream

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
setuptools: 47.3.1 -> 50.3.2
1b180e4 
reveals there's upstream work to be done for reproducibility
@FRidh
Copy link
Member

FRidh commented Dec 1, 2020 •
edited

Part of #105368

By the way, there is no need to open PR's for these core Python packages. They get updated every once in a while in a large batch.

@FRidh FRidh closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @FRidh