python: pip: 20.2.4 -> 20.3 #105540
Closed
python: pip: 20.2.4 -> 20.3 #105540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groodt
commented
Dec 1, 2020
| }; | ||
|
|
||
| nativeBuildInputs = [ bootstrapped-pip ]; | ||
|
|
||
| patches = lib.optionals isPy27 [ | ||
| (fetchpatch { | ||
| url = "https://github.com/pypa/pip/commit/94fbb6cf78c267bf7cdf83eeeb2536ad56cfe639.patch"; |
There was a problem hiding this comment.
This patch made it with the 20.3 release:
pypa/pip#8666
groodt
commented
Dec 1, 2020
| @@ -11,7 +11,7 @@ pipInstallPhase() { | |||
| export PYTHONPATH="$out/@pythonSitePackages@:$PYTHONPATH" | |||
|
|
|||
| pushd dist || return 1 | |||
| @pythonInterpreter@ -m pip install ./*.whl --no-index --no-warn-script-location --prefix="$out" --no-cache $pipInstallFlags --build tmpbuild | |||
There was a problem hiding this comment.
The --build argument has been deprecated in pip 20.3. See: pypa/pip#9049
10 tasks
|
Part of #105368. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates to the latest version of pip. I imagine this is a fairly large thing to test. I just thought that I'd throw up a PR in any case to get things started.
The
--buildargument has been deprecated in pip 20.3. See: pypa/pip#9049Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)