Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread explore page #653

Merged
merged 4 commits into from Nov 30, 2020
Merged

Proofread explore page #653

merged 4 commits into from Nov 30, 2020

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Nov 30, 2020

Someone pointed out the cool graphics on the Explore page and I noticed some typos while checking it out.

The second paragraph was hard to understand. How do you fix "it" (a
broken configuration run) locally before it happens? My interpretation
is it's about fixing problems that would cause CI to fail by testing
locally. And the nix benefit would be that the local and CI environments
will agree on the versions of testing and other tools which would run.
@toonn
Copy link
Contributor Author

toonn commented Nov 30, 2020

I'm on macOS and I wasn't able to get into a nix-shell to build and test my changes.

@garbas
Copy link
Member

garbas commented Nov 30, 2020

I'm not good with emojis (yet), but probably there is an emoji to give a hug. Thank you @toonn I really appreciate somebody doing a proofread.

I hope to make contributing a little easier (and possible on osx) with #652.

@garbas garbas self-requested a review November 30, 2020 18:26
@garbas garbas added the content label Nov 30, 2020
@garbas garbas merged commit 49596da into NixOS:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants