Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdftk: 3.0.8 -> 3.2.1 #105458

Merged
merged 1 commit into from Nov 30, 2020
Merged

pdftk: 3.0.8 -> 3.2.1 #105458

merged 1 commit into from Nov 30, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Nov 30, 2020

Motivation for this change

I did some basic testing by merging two PDFs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c November 30, 2020 16:02
@7c6f434c 7c6f434c merged commit ee1a1f8 into NixOS:master Nov 30, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 30, 2020 •
edited

Result of nixpkgs-review pr 105458 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • gscan2pdf
  • impressive
1 package failed to build:
  • pdftk
Welcome to Gradle 6.7!

Here are the highlights of this release:
 - File system watching is ready for production use
 - Declare the version of Java your build requires
 - Java 15 support

For more details see https://docs.gradle.org/6.7/release-notes.html

Using 4 worker leases.

FAILURE: Build failed with an exception.

* What went wrong:
Gradle could not start your build.
> Could not create service of type ResourceSnapshotterCacheService using GradleUserHomeServices.createResourceSnapshotterCacheService().
   > java.net.BindException: Operation not permitted (Bind failed)

* Try:
Run with --stacktrace option to get the stack trace. Run with --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

@7c6f434c
Copy link
Member

@SuperSandro2000 Any idea if anything can be built on macOS using this version of gradle?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 Any idea if anything can be built on macOS using this version of gradle?

I build something with gradle today which resulted in an hash mismatch.

#105590 (comment)

@primeos
Copy link
Member Author

primeos commented Dec 1, 2020 •
edited

@SuperSandro2000 in that case it could also work due to this. Anyway, feel free to investigate/fix or ping @NixOS/darwin-maintainers (but for pdftk it's probably not that important).

@SuperSandro2000
Copy link
Member

Yeah could be. I probably do not have time for that. I just mark the package broken on darwin for now.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 2, 2020
Merged
10 tasks
@xworld21 xworld21 mentioned this pull request Apr 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @SuperSandro2000 @7c6f434c