New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open-music-kontrollers: init #106822
open-music-kontrollers: init #106822
Conversation
5f7ae34
to
822c8c4
Compare
inherit description; | ||
|
||
src = fetchurl { | ||
url = url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of them at least can probably use fetchGit which should probably be used instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I do that in this situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure tbh because the sources are all a bit different. Maybe we can pass in src instead of url and sha256?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the downside of keeping it like this?
I find it quite elegant. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do these snapshots work? Do they need to be generated by hand? if so they could disappear and not exist for every commit so updating to another git rev would be unnecessarily hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are automatically generated.
Does that make my code OK, or did I misunderstand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it might be fine. Not fully sure to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in an ok state now?
5d276e2
to
40f06f3
Compare
I marked this as stale due to inactivity. → More info |
@papojari Thanks for the hint. |
I think it would make sense to make a category of these packages. |
@papojari What do you mean by category? |
a package set |
Like magnetophonDSP? |
yes, you already said it in the top comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the derivations looks fine, but at least lv2lint and patchmatrix are outdated. would also agree with @papojari that at least the lv2 plugins should not live at the nixpkgs toplevel, their names are a little too generic sometimes.
if you want to take over patchmatrix maintenance that's also fine, as long as we avoid having two of them :)
@papojari
Ah, yes, of course. Sorry for being slow. |
Shouldn't this be in the program itself? |
¯\_(ツ)_/¯ |
hi Synthpod by default runs plugin guis in separate processes and thus can mix plugins with gtk2 and gtk3 and (qt4 xor qt5) guis in the same project. The build system only supports qt4 or qt5 though, not both at the same time. The gtk/qt backends are optional as most plugin guis need a x11 backend. EDIT:
|
@ventosus Thanks for clearing that up! |
I'd argue in the other direction, there are hardly any Gtk3 Uis but loads of Gtk2, but well, I'm not running NixOS ;-)
|
Thanks, done. |
@magnetophon please rebase on master. |
OK, done. |
Thanks! |
Previously this was a WIP, now everything works.
Should I create a separate commit for each plugin?
Should each of those commits be on top of the last?
What about the entries in all-packages.nix; should I scatter them around or keep them grouped?
Maybe they should go in a subdomain, like
open-music-kontrollers.vm
, also because of the generic name of some of them.@SuperSandro2000 I fixed the merge conflict.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)